🦀 Update rust toolchain #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kailan
requested changes
Feb 2, 2021
There was a problem hiding this comment.
Woohoo! Thanks for this speedy fix, Katie.
Looks good apart from the CI version which probably needs updating too: https://github.com/fastly/cli/blob/master/.github/workflows/pr_test.yml#L53
Great catch! Fixed in 521d6a5. |
kailan
approved these changes
Feb 2, 2021
Integralist
approved these changes
Feb 2, 2021
|
Note: I'm waiting for a follow-up PR from @kailan which once reviewed/approved/merged I'll then cut a new CLI release. Likely a minor release (e.g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the CLI to pull our default Rust template from the
0.6.0branch. 1.Additionally, we bump the supported compiler version to
1.49.0, and update the test fixture inpkg/compute/testdata.