Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issues with Rust integration tests. #194

Merged
merged 4 commits into from
Jan 22, 2021

Conversation

Integralist
Copy link
Collaborator

The latest rust fastly crate release 0.6.0 (and subsequent fastly-sys crate release 0.3.7) bubbled up some bugs within the 'Rust Build' CLI integration tests (one example issue was not mocking the crate api endpoint sufficiently, which ultimately caused rust's cargo command to get confused).

@Integralist Integralist requested review from phamann and a team January 22, 2021 16:33
@Integralist
Copy link
Collaborator Author

@phamann just need your 👍🏻 up on this PR so I can unblock @jaredmorrow

Copy link
Member

@phamann phamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@Integralist Integralist added the bug Something isn't working label Jan 22, 2021
@Integralist Integralist merged commit 5b6b391 into master Jan 22, 2021
@Integralist Integralist deleted the integralist/20210122_fix_tests branch January 22, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants