Skip to content

[CDTOOL-1193] Support for Logging Endpoint Errors#1721

Merged
anthony-gomez-fastly merged 4 commits into
mainfrom
rcaril/CDTOOL-1193-support-for-logging-endpoint-errors
Apr 10, 2026
Merged

[CDTOOL-1193] Support for Logging Endpoint Errors#1721
anthony-gomez-fastly merged 4 commits into
mainfrom
rcaril/CDTOOL-1193-support-for-logging-endpoint-errors

Conversation

@rcaril

@rcaril rcaril commented Apr 9, 2026

Copy link
Copy Markdown
Member

Change summary

This PR adds support for the service logging debug commands, which streams logging endpoint errors.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?
 make test TEST_ARGS="-run TestParseLoggingError  ./pkg/commands/service/logging/debug"
ok      github.com/fastly/cli/pkg/commands/service/logging/debug        1.017s

Changes to Core Features:

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

Example Output:

INFO: Streaming logging endpoint errors for service <SID>

14:55:10 | Broken Log | Get "https://my-broken.logging.org/.well-known/fastly/logging/challenge": lookup my-broken.logging.org. on 127.0.0.1:53: no such host
14:55:21 | Broken Log | Get "https://my-broken.logging.org/.well-known/fastly/logging/challenge": lookup my-broken.logging.org. on 127.0.0.1:53: no such host
14:55:24 | Broken Log | Get "https://my-broken.logging.org/.well-known/fastly/logging/challenge": lookup my-broken.logging.org. on 127.0.0.1:53: no such host

Note: Claude Code was leveraged to build this feature

@rcaril rcaril force-pushed the rcaril/CDTOOL-1193-support-for-logging-endpoint-errors branch from 298e131 to 020be64 Compare April 9, 2026 19:17
@rcaril rcaril marked this pull request as ready for review April 9, 2026 19:19
@rcaril rcaril requested a review from a team as a code owner April 9, 2026 19:19

@kpfleming kpfleming left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine as-is, but I've suggested some minor improvements.

Comment thread pkg/commands/service/logging/debug/root.go Outdated
Comment thread pkg/commands/service/logging/debug/root.go Outdated

@anthony-gomez-fastly anthony-gomez-fastly left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anthony-gomez-fastly anthony-gomez-fastly enabled auto-merge (squash) April 10, 2026 16:58
@anthony-gomez-fastly anthony-gomez-fastly merged commit 79c36fa into main Apr 10, 2026
13 checks passed
@anthony-gomez-fastly anthony-gomez-fastly deleted the rcaril/CDTOOL-1193-support-for-logging-endpoint-errors branch April 10, 2026 17:02
jedisct1 added a commit to dip-proto/fastly-cli that referenced this pull request Apr 14, 2026
* main:
  build(deps): bump the go-dependencies group with 5 updates (fastly#1726)
  release 14.3.1 (fastly#1725)
  Restore permission for trusted publishing (fastly#1724)
  Release 14.3.0 (fastly#1723)
  [CDTOOL-1193]  Support for Logging Endpoint Errors (fastly#1721)
  chore(deps): bump go-fastly to 14.2.0 (fastly#1722)
  Add --json / -j flag to all stats subcommands (fastly#1719)
  build(deps): bump the go-dependencies group with 4 updates (fastly#1720)
  Add "auth revoke" subcommand for token revocation (fastly#1717)
  Restrict GitHub Actions workflow permissions to least privilege (fastly#1718)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants