feat(kvstoreentry): Support for missing CRUD attributes#1529
Merged
Conversation
- The new get function will now be operating as the prior describe function. - Encoded values in base64 for --verbose & --json
Contributor
Author
|
Will update CHANGELOG tomorrow. |
philippschulte
requested changes
Aug 29, 2025
Member
philippschulte
left a comment
There was a problem hiding this comment.
Overall this is a solid implementation. Please keep in mind that this introduces a breaking change for anyone who previously used fastly kv-store-entry describe -k foo -s bar to get the value. Please make sure to state it properly in the changelog. Please add the link to the docs in the PR description. Thank you!
philippschulte
approved these changes
Sep 3, 2025
kpfleming
requested changes
Sep 10, 2025
Contributor
kpfleming
left a comment
There was a problem hiding this comment.
Some minor changes to make but overall this looks great!
Co-authored-by: Kevin P. Fleming <kpfleming@users.noreply.github.com>
kpfleming
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
New Feature Submissions:
Changes to Core Features:
User Impact
getcommand that only provides thevalueof akeydescribeto now only provide the attributes of a key, rather than the value of a key itselfAre there any considerations that need to be addressed for release?
The following features are now supported:
Create:
Delete
Describe
Get
Tests: