Skip to content

refactor(pkg/serve): fix semgrep warnings #1521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anthony-gomez-fastly merged 1 commit into from
Aug 20, 2025
Merged

refactor(pkg/serve): fix semgrep warnings #1521

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions pkg/commands/compute/serve.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,8 @@ func (c *ServeCommand) Exec(in io.Reader, out io.Writer) (err error) {
enablePushpin := c.enablePushpin || c.Globals.Manifest.File.LocalServer.Pushpin.EnablePushpin
var pushpinCtx pushpinContext
if enablePushpin {
// The function checks for nil, so the semgrep warning is falsely triggered
// nosemgrep: trailofbits.go.invalid-usage-of-modified-variable.invalid-usage-of-modified-variable
pushpinCtx, err = c.startPushpin(spinner, out)
if err != nil {
pushpinCtx.Close()
Expand Down Expand Up @@ -591,7 +593,7 @@ func (c *ServeCommand) GetPushpinProxyPort(out io.Writer) (uint16, error) {
pushpinProxyPortStr := c.pushpinProxyPort
var pushpinProxyPort uint16
if pushpinProxyPortStr != "" {
pushpinProxyPortInt, err := strconv.Atoi(pushpinProxyPortStr)
pushpinProxyPortInt, err := strconv.ParseUint(pushpinProxyPortStr, 10, 16)
if err != nil {
return 0, fmt.Errorf("can't parse --pushpin-proxy-port value as a number: %s", pushpinProxyPortStr)
}
Expand Down Expand Up @@ -631,7 +633,7 @@ func (c *ServeCommand) GetPushpinPublishPort(out io.Writer) (uint16, error) {
pushpinPublishPortStr := c.pushpinPublishPort
var pushpinPublishPort uint16
if pushpinPublishPortStr != "" {
pushpinPublishPortInt, err := strconv.Atoi(pushpinPublishPortStr)
pushpinPublishPortInt, err := strconv.ParseUint(pushpinPublishPortStr, 10, 16)
if err != nil {
return 0, fmt.Errorf("can't parse --pushpin-publish-port value as a number: %s", pushpinPublishPortStr)
}
Expand Down
Loading