refactor(domainv1,tools): use updated go-fastly domainmanagement imports and types#1517
Merged
refactor(domainv1,tools): use updated go-fastly domainmanagement imports and types#1517
Conversation
rcaril
approved these changes
Aug 15, 2025
Contributor
rcaril
left a comment
There was a problem hiding this comment.
Looks good to me. Further validated locally.
Collaborator
Author
|
Thanks @rcaril am I ok to merge this or would you and your team prefer to handle merging? |
Contributor
I spoke to the team, it looks we prefer to merge on our side. I'll go ahead and do that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes to Core Features:
User Impact
There is no impact to the user. The changes as described in this PR are internal only. No package paths have changed, nor have any package names changed, nor have any CLI commands/subcommands changed. The only change has been to the go-fastly calls to match the latest go-fastly interface.
Are there any considerations that need to be addressed for release?
I have an internal conversation going to ascertain if this PR should be doing more (e.g. renaming command from domains-v1 to domain-management, as well as renaming the package path from domainv1 to domainmanagement). But even if we do want to go ahead with those changes we'll likely want to do that in a follow-up PR.