Add the ability to initialise a compute project from a specific branch #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbourgon
reviewed
Apr 6, 2020
peterbourgon
approved these changes
Apr 6, 2020
cratelyn
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
As requested by @katie-martin-fastly, this adds the ability to clone from a specific template repository branch when initialising a new Compute@Edge project via
compute init. We then use this logic to ensure that the default template is pointing to a named branch. This ensures we maintain compatibility with thefastlyguest crate API.Note
--branchflag hidden for the time being as we don't want to add confuse to the normal path of supplying templates repo urls.compute inittests and fixed a rendering issue with author, but are small enough changes that don't warrant their own PR.