Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logtail: add --timestamps flag #1254

Merged
merged 2 commits into from
Jul 26, 2024
Merged

logtail: add --timestamps flag #1254

merged 2 commits into from
Jul 26, 2024

Conversation

joeshaw
Copy link
Member

@joeshaw joeshaw commented Jul 26, 2024

This will print the timestamp of the request start time with each log
message.

This will print the timestamp of the request start time with each log
message.
pkg/commands/logtail/root.go Outdated Show resolved Hide resolved
@kpfleming
Copy link
Contributor

I was going to suggest enhancing the unit tests for logtail to test this new parameter... but there are no command-line unit tests for logtail :-(

@Integralist
Copy link
Collaborator

CI failed...

FAIL: TestInit/with_default_name_inferred_from_directory

@joeshaw
Copy link
Member Author

joeshaw commented Jul 26, 2024

CI failed...

I suspect this was a flake. It's unrelated to the change in any case. The additional commit has kicked off a rebuild, hopefully it'll clear up.

@kpfleming kpfleming self-requested a review July 26, 2024 19:17
@joeshaw joeshaw merged commit ad4b939 into main Jul 26, 2024
8 checks passed
@joeshaw joeshaw deleted the joeshaw/log-tail-timestamps branch July 26, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants