Allow compute services to be initialised from an existing service ID #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thommahoney
reviewed
Jun 9, 2020
thommahoney
approved these changes
Jun 11, 2020
Comment on lines
+278
to
+286
| { | ||
| name: "locked not latest", | ||
| inputVersions: []*fastly.Version{ | ||
| {Number: 1, Active: false, UpdatedAt: testutil.MustParseTimeRFC3339("2000-01-01T01:00:00Z")}, | ||
| {Number: 2, Active: false, Locked: true, UpdatedAt: testutil.MustParseTimeRFC3339("2000-01-02T01:00:00Z")}, | ||
| {Number: 3, Active: false, UpdatedAt: testutil.MustParseTimeRFC3339("2000-01-03T01:00:00Z")}, | ||
| }, | ||
| wantVersion: 2, | ||
| }, |
There was a problem hiding this comment.
This one is interesting. I wonder if we want 3 here.
phamann
force-pushed
the
phamann/init-from-service
branch
from
b26831b
to
3ee6114
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Refactors
compute initto accept a--service-idflag which will be used instead of provisioning a new service. This is an important feature request to bridge the UX flow between the UI -> CLI, i.e. this allows a user to first create a service via the UI and then move to the CLI to initialise the package.