Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds ResponseCondition and Placement fields to BigQuery Creates #111

Merged
merged 1 commit into from
Jun 4, 2020
Merged

Adds ResponseCondition and Placement fields to BigQuery Creates #111

merged 1 commit into from
Jun 4, 2020

Conversation

mccurdyc
Copy link
Collaborator

@mccurdyc mccurdyc commented Jun 2, 2020

Proposed Change(s)

  • Adds ResponseCondition and Placement fields to BigQuery Creates.

Relevant Link(s)/Documentation

Validation

$ make test

git clone git@github.com:mccurdyc/cli.git /tmp/cli && \
(
    cd /tmp/cli && \
    git checkout mccurdyc/logging-bq-add-fields && \
    make test && \
    rm -rf /tmp/cli \
)

@mccurdyc mccurdyc requested a review from phamann June 2, 2020 19:58
@mccurdyc mccurdyc changed the title Updates BigQuery to add supported fields to Create Adds ResponseCondition and Placement fields to BigQuery Creates Jun 2, 2020
@mccurdyc mccurdyc added the enhancement New feature or request label Jun 2, 2020
phamann
phamann approved these changes Jun 4, 2020
View reviewed changes
Copy link
Member

@phamann phamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

pkg/logging/bigquery/create.go Show resolved Hide resolved
@mccurdyc
logging: add supported ResponseCondition and Placement fields to Crea…
a6ce476 
…tes.

Signed-off-by: Colton J. McCurdy <cmccurdy@fastly.com>
@mccurdyc
Copy link
Collaborator Author

mccurdyc commented Jun 4, 2020

Force-pushed rebasing master.

@mccurdyc mccurdyc merged commit 7ec0040 into fastly:master Jun 4, 2020
@mccurdyc mccurdyc deleted the mccurdyc/logging-bq-add-fields branch June 4, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phamann phamann phamann approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mccurdyc @phamann