Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compute/deploy): support file field for kv_store setup #1040

Merged
merged 4 commits into from
Oct 11, 2023
Merged

fix(compute/deploy): support file field for kv_store setup #1040

merged 4 commits into from
Oct 11, 2023

Conversation

Integralist
Copy link
Collaborator

Fixes #1004

@Integralist Integralist added the enhancement New feature or request label Oct 11, 2023
grantstephens
grantstephens approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@grantstephens grantstephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small queries, but otherwise LGTM

pkg/commands/compute/setup/kv_store.go Show resolved Hide resolved
pkg/commands/compute/setup/kv_store.go Show resolved Hide resolved
@Integralist Integralist merged commit b8b1ce3 into main Oct 11, 2023
6 checks passed
@Integralist Integralist deleted the integralist/setup-kv-file branch October 11, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grantstephens grantstephens grantstephens approved these changes

@JakeChampion JakeChampion JakeChampion approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Ability to use files for [setup.kv_stores] section
3 participants
@Integralist @JakeChampion @grantstephens