Update after parameter name change in Viceroy #1033
Conversation
fgsch
changed the title
| @@ -568,7 +568,7 @@ func local(opts localOpts) error { | |||
| if opts.profileGuestDir.WasSet { | |||
| directory = opts.profileGuestDir.Value | |||
| } | |||
| args = append(args, "--profile-guest="+directory) | |||
| args = append(args, "--profile=guest,"+directory) | |||
There was a problem hiding this comment.
Will this cause a break for users with an older Viceroy version?
There was a problem hiding this comment.
Yes, it will if they have a specific (old) version pinned down somehow.
I say pinned down because Viceroy 0.9.0, the version that contains this change, was released yesterday, and the CLI update mechanism should have updated Viceroy by the time a CLI release includes the compute serve --profile-guest parameter.
There was a problem hiding this comment.
Ah yes, #1019 was merged but hasn't actually been published in a release yet.
So this PR doesn't break anything because the thing it changes hasn't yet been released.
So by the time we cut a new CLI release, most users will have the newer version of Viceroy installed.
As for users who have an older Viceroy pinned, I think you could update the --profile-guest flag description to state that the flag is for Viceroy 0.9.1+.
There was a problem hiding this comment.
Good idea. Thank you. Updated.
fgsch
force-pushed
the
fgsch/update-viceroy-cmd-line
branch
from
e8cdf51
to
c15547b
Compare
Sync with Viceroy 0.9.0.