Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compute/deploy): check package before service clone #1026

Merged
merged 4 commits into from
Oct 6, 2023
Merged

fix(compute/deploy): check package before service clone #1026

merged 4 commits into from
Oct 6, 2023

Conversation

Integralist
Copy link
Collaborator

No description provided.

@Integralist Integralist added the bug Something isn't working label Oct 2, 2023
@Integralist Integralist requested a review from fgsch October 2, 2023 12:57
@Integralist Integralist force-pushed the integralist/package-check branch 3 times, most recently from 41ebdb9 to 9c611d5 Compare October 2, 2023 16:10
@Integralist Integralist marked this pull request as ready for review October 2, 2023 16:24
fgsch
fgsch approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@fgsch fgsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested but code LGTM.

@Integralist Integralist merged commit 349975b into main Oct 6, 2023
6 checks passed
@Integralist Integralist deleted the integralist/package-check branch October 6, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgsch fgsch fgsch approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Integralist @fgsch