Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: drop Node.js 10 and 12 #15

Merged
merged 3 commits into from
May 5, 2022
Merged

ci: drop Node.js 10 and 12 #15

merged 3 commits into from
May 5, 2022

Conversation

darkgl0w
Copy link
Member

@darkgl0w darkgl0w commented Feb 25, 2022

Hello.

This PR aims to :

  • drop Node.js version 10 whose support has ended since 04/30/2021
  • drop Node.js version 12 whose support ends 04/30/2022

Checklist

@mcollina
Copy link
Member

Doing this is a semver-major change for all modules.

@Fdawgs
Copy link
Member

Fdawgs commented Feb 25, 2022

I think it's best to hold fire on this until Fastify v4, and then drop node 10 and 12 at the same time. 😁

@darkgl0w
Copy link
Member Author

darkgl0w commented Feb 25, 2022

I will update the PR to drop Node.js 12 at the same time and we will wait until v4 is released :d

@darkgl0w darkgl0w changed the title ci: drop Node.js 10 ci: drop Node.js 10 and 12 Feb 25, 2022
@mcollina
Copy link
Member

Could the workflows have a version number?

@climba03003
Copy link
Member

Could the workflows have a version number?

Yes, and it need to manage multiple tag. e.g. 3.0.0 needs v3, v3.0 and v3.0.0 tags.

@mcollina
Copy link
Member

I would recommend to land this a semver-major thenz

@Fdawgs
Copy link
Member

Fdawgs commented Feb 28, 2022

I'm hesitant to land this and release a new major (v3) until Fastify v4. Dependabot will automatically bump all repos currently using this workflow from v2 to the new v3, thus dropping all testing for node 10 and 12 before we officially move away from them in v4.

@mcollina
Copy link
Member

mcollina commented Mar 2, 2022

Ok, let's do this as part of the release choreograpy. Could you add it to the issue?

Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think node@18 will release (2022-04-19) faster than fastify@4 release cycle. I drop a Request Changes here for reminder.

@darkgl0w
Copy link
Member Author

darkgl0w commented Mar 5, 2022

I think node@18 will release (2022-04-19) faster than fastify@4 release cycle. I drop a Request Changes here for reminder.

I will add 18 to the matrix when they cut the 18th branch.
Usually a major branch is cut before the LTS release.

(would be good if GitHub had a reminder feature :d)

@Fdawgs
Copy link
Member

Fdawgs commented May 5, 2022

As v4 is now being worked on in the modules themselves (fastify/fastify-compress#224), maybe now is a good time to land this?

@mcollina
Copy link
Member

mcollina commented May 5, 2022

We really need a way to have multiple version of our workflow.

@Fdawgs Fdawgs merged commit f98ce27 into fastify:main May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants