-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: drop Node.js 10 and 12 #15
Conversation
Doing this is a semver-major change for all modules. |
I think it's best to hold fire on this until Fastify v4, and then drop node 10 and 12 at the same time. 😁 |
I will update the PR to drop Node.js 12 at the same time and we will wait until v4 is released :d |
Could the workflows have a version number? |
Yes, and it need to manage multiple tag. e.g. |
I would recommend to land this a semver-major thenz |
I'm hesitant to land this and release a new major (v3) until Fastify v4. Dependabot will automatically bump all repos currently using this workflow from v2 to the new v3, thus dropping all testing for node 10 and 12 before we officially move away from them in v4. |
Ok, let's do this as part of the release choreograpy. Could you add it to the issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think node@18
will release (2022-04-19) faster than fastify@4
release cycle. I drop a Request Changes here for reminder.
I will add 18 to the matrix when they cut the 18th branch. (would be good if GitHub had a reminder feature :d) |
As v4 is now being worked on in the modules themselves (fastify/fastify-compress#224), maybe now is a good time to land this? |
We really need a way to have multiple version of our workflow. |
Hello.
This PR aims to :
Checklist
npm run test
andnpm run benchmark
and the Code of conduct