Conversation
Related to fastify/.github#37. This is just a proposal, probably not comprehensive of all the places where a similar change may have to occur, simply to capture that this is possible (and I didn't know until now) to exclude combinations, as documented in https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#excluding-matrix-configurations Signed-off-by: Simone Busoli <simone.busoli@gmail.com>
gurgunday
left a comment
gurgunday
left a comment
There was a problem hiding this comment.
I agree with the change
Would have to be backported to v3.y.z
Fdawgs
left a comment
Fdawgs
left a comment
There was a problem hiding this comment.
It needs to be applied to the rest of the workflows in this repo, does it not?
|
yes |
gurgunday
left a comment
gurgunday
left a comment
There was a problem hiding this comment.
So that someone doesn't merge it:
|
Folks feel free to push to this branch, I was only intending to capture the way to do it |
|
I'm not entirely comfortable in shipping this change myself, because there is a bit of automation here that I know nothing about (I think). If somebody familiar can ship, it would unblock a few PRs that are currently failing everywhere. |
|
I'll do it, just need a second to clone |
Everything else runs only on ubuntu, because services already require it like you said, so we should be good, no?
We just tag a new version from main for now, without using the workflow Then we should cherry pick to |
|
I’ll backport it to v3 now |
* chore: exclude Node 14 and 16 on macos Related to fastify/.github#37. This is just a proposal, probably not comprehensive of all the places where a similar change may have to occur, simply to capture that this is possible (and I didn't know until now) to exclude combinations, as documented in https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#excluding-matrix-configurations Signed-off-by: Simone Busoli <simone.busoli@gmail.com> * remove os matrix from package --------- Signed-off-by: Simone Busoli <simone.busoli@gmail.com> Co-authored-by: Gürgün Dayıoğlu <hey@gurgun.day>
* chore: exclude Node 14 and 16 on macos Related to fastify/.github#37. This is just a proposal, probably not comprehensive of all the places where a similar change may have to occur, simply to capture that this is possible (and I didn't know until now) to exclude combinations, as documented in https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#excluding-matrix-configurations * remove os matrix from package --------- Signed-off-by: Simone Busoli <simone.busoli@gmail.com>
5 participants
Related to fastify/.github#37.
This is just a proposal, probably not comprehensive of all the places where a similar change may have to occur, simply to capture that this is possible (and I didn't know until now) to exclude combinations, as documented in https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#excluding-matrix-configurations
Checklist
npm run testandnpm run benchmarkand the Code of conduct