Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make node versions dynamic #124

Merged
merged 12 commits into from
Apr 23, 2024
Merged

Make node versions dynamic #124

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
9c5960e
use default node versions
gurgunday Apr 19, 2024
4dac12a
add to other workflows
gurgunday Apr 21, 2024
5ffa218
Merge branch 'main' of https://github.com/fastify/workflows into dyna…
gurgunday Apr 21, 2024
72a4202
spacing
gurgunday Apr 21, 2024
b1b61d5
Merge branch 'main' of https://github.com/fastify/workflows into dyna…
gurgunday Apr 22, 2024
c269ffd
remove os matrix when it's not used
gurgunday Apr 22, 2024
e99e44f
spacing
gurgunday Apr 22, 2024
6667738
only test package managers on ubuntu, as is the case with fastify/fas…
gurgunday Apr 22, 2024
2b5421e
update readme
gurgunday Apr 22, 2024
6724e17
update desc
gurgunday Apr 22, 2024
3b816fd
remove stringified
gurgunday Apr 22, 2024
815aca9
don't add matrix is to benchmark
gurgunday Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/plugins-benchmark-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,12 @@ on:
type: string
default: ${{ github.event.pull_request.base.ref }}
required: false
node-versions:
description: 'A comma-separated list of Node versions to test against.'
required: false
default: '["18", "20", "21"]'
type: string

jobs:
benchmark:
if: ${{ github.event.label.name == 'benchmark' }}
Expand All @@ -47,7 +53,8 @@ jobs:

strategy:
matrix:
node-version: [18, 20, 21]
node-version: ${{ fromJson(inputs.node-versions) }}
os: [macos-latest, ubuntu-latest, windows-latest]
steps:
- name: Checkout ${{ inputs.pr-repo }}@${{ inputs.pr-ref }}
uses: actions/checkout@v4
Expand Down
9 changes: 7 additions & 2 deletions .github/workflows/plugins-ci-mongo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@ on:
required: false
default: false
type: boolean
node-versions:
description: 'A comma-separated list of Node versions to test against.'
required: false
default: '["18", "20", "21"]'
type: string

jobs:
dependency-review:
Expand Down Expand Up @@ -98,8 +103,8 @@ jobs:
contents: read
strategy:
matrix:
node-version: [18, 20, 21]
os: [ubuntu-latest]
node-version: ${{ fromJson(inputs.node-versions) }}
os: [macos-latest, ubuntu-latest, windows-latest]
db: [5]

services:
Expand Down
9 changes: 7 additions & 2 deletions .github/workflows/plugins-ci-mysql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@ on:
required: false
default: false
type: boolean
node-versions:
description: 'A comma-separated list of Node versions to test against.'
required: false
default: '["18", "20", "21"]'
type: string

jobs:
dependency-review:
Expand Down Expand Up @@ -100,8 +105,8 @@ jobs:
contents: read
strategy:
matrix:
node-version: [18, 20, 21]
os: [ubuntu-latest]
node-version: ${{ fromJson(inputs.node-versions) }}
os: [macos-latest, ubuntu-latest, windows-latest]
db: ['mysql:8.0']

services:
Expand Down
14 changes: 10 additions & 4 deletions .github/workflows/plugins-ci-package-manager.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@ name: Plugin CI - Package Managers

on:
workflow_call:
inputs:
node-versions:
description: 'A comma-separated list of Node versions to test against.'
required: false
default: '["18", "20", "21"]'
type: string

jobs:
pnpm:
Expand All @@ -11,8 +17,8 @@ jobs:
contents: read
strategy:
matrix:
node-version: [18, 20, 21]
os: [ubuntu-latest]
node-version: ${{ fromJson(inputs.node-versions) }}
os: [macos-latest, ubuntu-latest, windows-latest]
pnpm-version: [8]

steps:
Expand Down Expand Up @@ -44,8 +50,8 @@ jobs:
contents: read
strategy:
matrix:
node-version: [18, 20, 21]
os: [ubuntu-latest]
node-version: ${{ fromJson(inputs.node-versions) }}
os: [macos-latest, ubuntu-latest, windows-latest]
steps:
- name: Check out repo
uses: actions/checkout@v4
Expand Down
9 changes: 7 additions & 2 deletions .github/workflows/plugins-ci-postgres.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@ on:
required: false
default: false
type: boolean
node-versions:
description: 'A comma-separated list of Node versions to test against.'
required: false
default: '["18", "20", "21"]'
type: string

jobs:
dependency-review:
Expand Down Expand Up @@ -98,8 +103,8 @@ jobs:
contents: read
strategy:
matrix:
node-version: [18, 20, 21]
os: [ubuntu-latest]
node-version: ${{ fromJson(inputs.node-versions) }}
os: [macos-latest, ubuntu-latest, windows-latest]
gurgunday marked this conversation as resolved.
Show resolved Hide resolved
db: ['postgres:11-alpine']

services:
Expand Down
8 changes: 7 additions & 1 deletion .github/workflows/plugins-ci-redis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@ on:
required: false
default: false
type: boolean
node-versions:
description: 'A comma-separated list of Node versions to test against.'
required: false
default: '["18", "20", "21"]'
type: string

jobs:
dependency-review:
Expand Down Expand Up @@ -96,7 +101,8 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [18, 20, 21]
node-version: ${{ fromJson(inputs.node-versions) }}
os: [macos-latest, ubuntu-latest, windows-latest]
db: [5, 6, 7]
services:
redis:
Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/plugins-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@ on:
required: false
default: false
type: boolean
node-versions:
description: 'A comma-separated list of Node versions to test against.'
required: false
default: '["18", "20", "21"]'
type: string

jobs:
dependency-review:
Expand Down Expand Up @@ -103,7 +108,7 @@ jobs:
contents: read
strategy:
matrix:
node-version: [18, 20, 21]
node-version: ${{ fromJson(inputs.node-versions) }}
os: [macos-latest, ubuntu-latest, windows-latest]
steps:
- name: Check out repo
Expand Down