-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add link to new fastify website repository on organisations page #76
Conversation
versions-shipped.json
Outdated
@@ -1 +1,156 @@ | |||
[] | |||
[ | |||
"1.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Eomm these versions were generated when i ran npm run build:website
wondering if i missed something to ignore them....or they are supposed to be removed manually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wondering if i missed something to ignore them....or they are supposed to be removed manually
Right now they should be removed manually from the commit - will find a better approach with #46
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After working on CI&CD I think we are not going to rename the repo (at least in the immediate future).
So I think this PR is valuable and should be merged 👍🏼
@HassanBahati could you revert the changes to the *.json
files so we can land it?
yah sure, let me do so |
- undo changes in version.json - undo changes in versions.shipped.json
Checklist
npm run test
andnpm run benchmark
and the Code of conduct