Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add link to new fastify website repository on organisations page #76

Merged
merged 5 commits into from
May 3, 2023

Conversation

HassanBahati
Copy link
Contributor

Checklist

@HassanBahati HassanBahati changed the title fix: add link to new fastify website repository to organisations page fix: add link to new fastify website repository on organisations page Feb 14, 2023
@@ -1 +1,156 @@
[]
[
"1.0.0",
Copy link
Contributor Author

@HassanBahati HassanBahati Feb 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Eomm these versions were generated when i ran npm run build:website

wondering if i missed something to ignore them....or they are supposed to be removed manually

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering if i missed something to ignore them....or they are supposed to be removed manually

Right now they should be removed manually from the commit - will find a better approach with #46

@HassanBahati HassanBahati temporarily deployed to github-pages February 14, 2023 10:50 — with GitHub Actions Inactive
@Eomm Eomm linked an issue Apr 25, 2023 that may be closed by this pull request
2 tasks
Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After working on CI&CD I think we are not going to rename the repo (at least in the immediate future).

So I think this PR is valuable and should be merged 👍🏼

@HassanBahati could you revert the changes to the *.json files so we can land it?

@HassanBahati
Copy link
Contributor Author

@HassanBahati could you revert the changes to the *.json files so we can land it?

yah sure, let me do so

HassanBahati and others added 3 commits May 3, 2023 14:43
@Eomm Eomm merged commit 90e0341 into fastify:main May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fasitfy website repository link points to old website repository
3 participants