-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docusaurus v3 upgrade #223
Conversation
@Eomm There are some issues causes by upgrading docusaurus to v3 noteable the formatting from some files in the fastify/fastify docs. The previous versions of the docs have formarting (notably ones identified by running npx docusaurus-mdx-checker). The updrage to v3 might have to include seperate docs for v2 and below and v3 and above. Not sure how to achieve this but I just wanted to raise a potential bottleneck. In addition orama plugin for docusaurua moved from @orama/plugin-docusaurus to @orama/plugin-docusaurus-v3 . I have temporarily commented out the plugin in docusaurus config because it brought up some issues but Im currently working to resolve it. |
versions-shipped.json
Outdated
@@ -1 +1,187 @@ | |||
[] | |||
[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the version*
files should not be committed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well noted
Some example? I don't get if it breaks the website build or the linting. |
Can we do some regexp magic like this? website/scripts/process-releases.js Lines 105 to 113 in e3e433a
|
Really smart approach...Lemmi try to come up with some magic to address the issue. Also Ive just remembered that to ensure the docs in fastify/fastify continue to be compatible with docusaurus v3 we also need to ensure it runs
as a requirement during build time |
…rus v3 guidelines
…rus v3 guidelines
Need to check this PR - I will do it - I'm just doing to many things 🥲 |
@Eomm I also got a bit held up but Im back on it to ensure we have passing build before you review it..there some hitches as I was trying to upgrade but will notify you incase I make a breakthrough |
3de85d2
to
8633c45
Compare
Signed-off-by: Manuel Spigolon <behemoth89@gmail.com>
Sorry @james-kaguru , I want to ship this PR very soon 😮💨 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FINALLY!
Thanks @james-kaguru
Description
This upgraded the project dependancies to match up to what is required in docusaurus v3
Related Issues
#212
Check List