-
-
Notifications
You must be signed in to change notification settings - Fork 54
Implemented way to customize session-id retrieval/storage #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Levyks
wants to merge
2
commits into
fastify:main
Choose a base branch
from
Levyks:feature/custom-session-id-store
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| module.exports = { | ||
| get: (request, key) => request.cookies[key], | ||
| set: (reply, key, value, opts) => reply.setCookie(key, value, opts), | ||
| clear: (reply, key, opts) => reply.clearCookie(key, opts) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| 'use strict' | ||
|
|
||
| const test = require('node:test') | ||
| const Fastify = require('fastify') | ||
| const fastifyCookie = require('@fastify/cookie') | ||
| const fastifySession = require('../lib/fastifySession') | ||
| const { DEFAULT_OPTIONS, DEFAULT_SESSION_ID, DEFAULT_ENCRYPTED_SESSION_ID } = require('./util') | ||
|
|
||
| const idStore = { | ||
| get: (request, key) => request.headers[key.toLowerCase()], | ||
| set: (reply, key, value) => reply.header(key, value), | ||
| clear: (reply, key) => reply.removeHeader(key) | ||
| } | ||
|
|
||
| test('should set sessionid header with custom id store', async (t) => { | ||
| t.plan(3) | ||
| const fastify = Fastify() | ||
| let sessionId = null | ||
|
|
||
| fastify.addHook('onRequest', async (request) => { | ||
| request.raw.socket.encrypted = true | ||
| }) | ||
| fastify.register(fastifyCookie) | ||
| fastify.register(fastifySession, { | ||
| ...DEFAULT_OPTIONS, | ||
| idStore | ||
| }) | ||
| fastify.get('/', (request, reply) => { | ||
| request.session.test = {} | ||
| sessionId = request.session.sessionId | ||
| reply.send(200) | ||
| }) | ||
| await fastify.listen({ port: 0 }) | ||
| t.after(() => { fastify.close() }) | ||
|
|
||
| const response = await fastify.inject({ | ||
| url: '/' | ||
| }) | ||
|
|
||
| t.assert.strictEqual(response.statusCode, 200) | ||
| t.assert.ok(sessionId) | ||
| const pattern = `${sessionId}\\..{43,57}` | ||
| t.assert.strictEqual(new RegExp(pattern).test(response.headers['sessionid']), true) | ||
| }) | ||
|
|
||
| test('should retrieve sessionid header with custom id store', async (t) => { | ||
| t.plan(2) | ||
| const fastify = Fastify() | ||
|
|
||
| fastify.register(fastifyCookie) | ||
| fastify.register(fastifySession, { | ||
| ...DEFAULT_OPTIONS, | ||
| idStore, | ||
| store: { | ||
| get (id, cb) { cb(null, { id }) }, | ||
| } | ||
| }) | ||
| fastify.get('/', (request, reply) => { | ||
| t.assert.strictEqual(request.session.sessionId, DEFAULT_SESSION_ID) | ||
| reply.send(200) | ||
| }) | ||
| await fastify.listen({ port: 0 }) | ||
| t.after(() => { fastify.close() }) | ||
|
|
||
| const response = await fastify.inject({ | ||
| url: '/', | ||
| headers: { | ||
| sessionid: DEFAULT_ENCRYPTED_SESSION_ID | ||
| } | ||
| }) | ||
|
|
||
| t.assert.strictEqual(response.statusCode, 200) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -155,6 +155,12 @@ declare namespace fastifySession { | |
| */ | ||
| store?: fastifySession.SessionStore; | ||
|
|
||
| /** | ||
| * A session ID store. | ||
| * Defaults to a cookie based store. | ||
| */ | ||
| idStore?: SessionIdStore; | ||
|
|
||
| /** | ||
| * Save sessions to the store, even when they are new and not modified. | ||
| * Defaults to true. Setting this to false can be useful to save storage space and to comply with the EU cookie law. | ||
|
|
@@ -182,6 +188,12 @@ declare namespace fastifySession { | |
| maxAge?: number; | ||
| } | ||
|
|
||
| export interface SessionIdStore { | ||
| get: (request: Fastify.FastifyRequest, key: string) => string | undefined; | ||
| set?: (reply: Fastify.FastifyReply, key: string, value: string, cookieOptions: CookieOptions) => void; | ||
| clear?: (reply: Fastify.FastifyReply, key: string, cookieOptions: CookieOptions) => void; | ||
|
Comment on lines
+193
to
+194
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's the decision behind making |
||
| } | ||
|
|
||
| export class MemoryStore implements fastifySession.SessionStore { | ||
| constructor (map?: Map<string, Fastify.Session>) | ||
| set ( | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.