Skip to content

Fix safe handling of constructor null values #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 1, 2025

Conversation

mcollina
Copy link
Member

Summary

Test plan

  • All existing tests pass
  • Added new test case for constructor null handling
  • Verified no regression in security behavior
  • Linting and code standards maintained

🤖 Generated with Claude Code

mcollina and others added 3 commits May 31, 2025 15:54
Add defensive null checking in scan function to prevent potential TypeError
when constructor property is set to null. This addresses issue #141 where
accessing constructor.prototype could fail if constructor is null.

Changes:
- Enhanced scan function with safe constructor value checking
- Added test case for constructor null handling
- Maintains existing security behavior and test coverage

Fixes #141

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Resolves merge conflicts by integrating the enhanced constructor.prototype
checking from main branch with safe null handling for issue #141.

Changes:
- Added null checks before accessing constructor.prototype
- Enhanced test coverage for constructor null scenarios
- Maintains compatibility with new main branch structure

Fixes #141

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Matteo Collina <hello@matteocollina.com>
- Remove trailing spaces in test file to satisfy neostandard linting
- Update CLAUDE.md with current project structure and tooling:
  * Changed from standard to neostandard with ESLint 9
  * Updated test commands and structure (test/ directory)
  * Added TypeScript support information
  * Enhanced security details about constructor.prototype handling

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 😅

- Remove CLAUDE.md from git tracking while keeping local copy
- Add CLAUDE.md and .claude directory to .gitignore

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Uzlopak Uzlopak merged commit 3c91426 into main Jun 1, 2025
11 checks passed
@Uzlopak Uzlopak deleted the fix/constructor-null-handling branch June 1, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception thrown when constructor is null
4 participants