Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: use node: prefix to bypass require.cache call for builtins #51

Merged
merged 2 commits into from
Sep 12, 2023
Merged

perf: use node: prefix to bypass require.cache call for builtins #51

merged 2 commits into from
Sep 12, 2023

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Sep 10, 2023 •
edited
Loading

See fastify/fastify-static#407

Checklist

@Fdawgs
Copy link
Member Author

Fdawgs commented Sep 11, 2023

@Uzlopak are you doing this as part of #52? If so i'll close this. :)

@Uzlopak
Copy link
Contributor

Uzlopak commented Sep 11, 2023

Please handle my PR #52 as it does not exist yet. Dont want that this PR, which could be merged independently, gets blocked by my potentially unfinished work.

mcollina
mcollina approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit b49428c into master Sep 12, 2023
17 checks passed
@gurgunday gurgunday deleted the perf/builtins branch April 17, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fdawgs @Uzlopak @mcollina