Add createDeprecation method #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsumners
force-pushed
the
support-deprecation-warnings
branch
from
7cdd1bb
to
850ff68
Compare
jsumners
force-pushed
the
support-deprecation-warnings
branch
from
850ff68
to
3be4cb3
Compare
Uzlopak
approved these changes
Oct 27, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking through the documentation while reviewing another PR this morning and discovered that we do not provide a mechanism to support Node's extended support for deprecation warning. Namely, we don't provide a way to create a deprecation warning that can be traced with
--trace-deprecation, thrown with--throw-deprecation, or silenced with--no-deprecation. So I decided to add it in as bonus functionality.While I was at it, I fixed the lack of jsdoc.
Checklist
npm run testandnpm run benchmarkand the Code of conduct