perf: use node: prefix to bypass require.cache call for builtins
#81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pointing out that applications using node versions under 16 will break. At least it happened with my fragile version 14-alpine on Dockerfile 😢 |
|
@LucasHang |
Oh sorry, my bad. Taking a quick look on node docs I only found the package "util" being imported with "node:" on version 16.x, then I felt the need of pointing out, thinking it to be a breaking change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See fastify/fastify-static#407
Checklist
npm run testandnpm run benchmarkand the Code of conduct