refactor: name Fastify hook handlers #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fdawgs
requested changes
Nov 10, 2025
Member
Fdawgs
left a comment
Fdawgs
left a comment
There was a problem hiding this comment.
Please revert stylistic changes like whitespace, quotes etc.
Contributor
Author
Done. Sorry for that |
Member
Quite a lot still there |
emicovi
force-pushed
the
feat/named-hooks
branch
from
fb21ff3 to
a230196
Compare
Contributor
Author
Rebased on latest upstream/main and force-pushed. Thanks again |
Eomm
reviewed
Nov 10, 2025
Contributor
Author
|
Applied suggestion. Thanks |
metcoder95
reviewed
Nov 11, 2025
metcoder95
changed the title
Eomm
reviewed
Nov 12, 2025
Fdawgs
changed the title
Eomm
reviewed
Nov 17, 2025
Eomm
reviewed
Nov 17, 2025
metcoder95
approved these changes
Nov 18, 2025
Eomm
approved these changes
Nov 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This patch gives explicit names to internal Fastify hook callbacks used by the OpenTelemetry instrumentation plugin so spans show meaningful callback names instead of anonymous functions.
What changed
instance.addHookfor:onRoute→onRouteHookonRequest→onRequestHookonResponse→onResponseHookCHANGELOG.mdreferencing this change.Why
Named hook handlers improve span attribution in tracing and align with the repository-wide initiative to avoid anonymous hook handlers (see issue #110). This is a non-behavioral refactor intended to make traces clearer and easier to debug.
Tests
npm testRelated
Notes