Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work for git submodules #95

Closed
2 tasks done
sitiom opened this issue Nov 4, 2021 · 0 comments · Fixed by #99
Closed
2 tasks done

Does not work for git submodules #95

sitiom opened this issue Nov 4, 2021 · 0 comments · Fixed by #99

Comments

@sitiom
Copy link

sitiom commented Nov 4, 2021

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the regression has not already been reported

Last working version

2.1.1

Stopped working in version

2.2.0

Node.js version

N/A

Operating system

Linux

Operating system version (i.e. 20.04, 11.3, 10)

20.04

💥 Regression Report

Updating git submodules stopped working in 2.2.0 due to the newly added target parameter. Submodules are updated by new commits, and so they fail the SemVer check (compared by hashes):

Workflow error

Steps to Reproduce

  • Add a submodule in your repo
  • Create a dependabot workflow to update submodules:
version: 2
updates:
  - package-ecosystem: "gitsubmodule"
    directory: "/"
    schedule:
      interval: "daily"
  • Create a simple GitHub action for fastify/github-action-merge-dependabot

Expected Behavior

It should just ignore git submodules and automatically merge them regardless. A skip option for target would be a solution for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant