"any" value added to target option #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simoneb
reviewed
Nov 11, 2021
|
yeah I think |
|
@simoneb is this PR good to merge? I had updated the test cases. |
simoneb
requested changes
Nov 12, 2021
The nested tests were already there. I have eliminated the nesting and improved the structure now. Please review. |
simoneb
approved these changes
Nov 12, 2021
There was a problem hiding this comment.
The nesting made sense, it just didn't make much sense after you had changed it.
It made sense because previously we returned major when:
- major was provided
- input was not recognized
With your change "any" would have got the same behavior as major had previously but you didn't update the structure of the tests accordingly.
Without nesting the problem does not exist in the first place so we're good
nuragic
added a commit
to nuragic/github-action-merge-dependabot
that referenced
this pull request
Dec 7, 2021
The default value for `target` was still `major` but it has been changed to `any` here fastify#99.
simoneb
pushed a commit
that referenced
this pull request
Dec 7, 2021
The default value for `target` was still `major` but it has been changed to `any` here #99.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The target value can be one of the
major, premajor, minor, preminor, patch, prepatch or prerelease. This PR adds another valueanywhich can be used to run the action without any semver version checks.Documentation has been updated
Closes #95