extend api wrong typings

[climba03003]

🐛 Bug Report

After the Schema extend other Schema, some of the api will be missing.

To Reproduce

Steps to reproduce the behavior:

const Base = S.object()
  .prop('foo', S.string())

const Extend = S.object()
  .prop('bar', S.string())
  .extend(Base)
  .required(['foo', 'bar']) // missing endpoint here

Expected behavior

const Base = S.object()
  .prop('foo', S.string())

const Extend = S.object()
  .prop('bar', S.string())
  .extend(Base)
  .required(['foo', 'bar']) // without error

Your Environment

• node version: 14
• fastify version: >=2.0.0
• os: Linux
• any other relevant information

[climba03003]

After digging into the closed issue. I can see that this behavior is made on purpose.
Related Issue #69 and #75

However, I think it should allow the required api after the extend.
The main reason is that I think most of the people need the required attributes after extend multiple schema.

[aboutlo]

  const Extend = S.object()
     .prop('bar', S.string())
     .required(['foo', 'bar']) 
     .extend(Base)

You can't require before the extend.

{
   "$schema":"http://json-schema.org/draft-07/schema#",
   "type":"object",
   "properties":{
      "foo":{
         "type":"string"
      },
      "bar":{
         "type":"string"
      }
   },
   "required":[
      "foo",
      "bar"
   ]
}

[climba03003]

It just inconvenient for the user to remember all work need to be done before extend.
Another thing is the typescript typing is wrong for extend. Therefore, I think require can be done after extend.

In conclude, some more work need to be done for the extend API.

1. typing should be fixed ASAP.
2. better documentation for extend API

[aboutlo]

Feel free to open a MR ASAP to improve the types

On Mon, 21 Sep 2020 at 15:31, climba03003 ***@***.***> wrote: It just inconvenient for the user to remember all work need to be done before extend. Another thing is the typescript typing is wrong for extend. Therefore, I have require can be done after extend. The typing should be fixed ASAP. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#79 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJN2LCOMI76YLZX7FE7S2LSG5PT7ANCNFSM4RUHZB2Q> . --

Sent from mobile phone