Hack workaround for multiple-extend

[dfee]

🐛 Bug Report

multiple extend was broken here: #69
it was sort of fixed here: #74

however, the result is the hack function below to extend multiple times:

export const extendMultiple = (...schemas: ObjectSchema[]): ObjectSchema =>
  schemas.reduce((prev, curr) => curr.extend(prev), S.object());

To Reproduce

// extend is not a function (technically, the second extend doesn't exist)
S.object().extend(S.object()).extend(S.object())

// ...or
const schema = extendMultiple(S.object(), S.object(), S.object());

Expected behavior

extend shouldn't be excluded from the return value here: https://github.com/fastify/fluent-schema/blob/5ffffb8110a6fe845ca6cd7bbaaf2dc358960b5a/src/ObjectSchema.js#L261-L278

Your Environment

• node version: 12
• os: Mac,
• fluent-schema version: 1.0.3

[dfee]

Also, it's unclear what this means:

I decided to block all the method after .extend to avoid incorrect usage.

from #69 (comment)

What is the incorrect usage?

[aboutlo]

const base = S.object()
  .extend(SCHEMA_BASE)
  .prop(
    'reason',
    S.string()
      .minLength(1)
  )

the fact that you first extend then you add the prop it could easily create confusion.

On the other hand, this is a fair case

S.object().extend(S.object()).extend(S.object())

[dfee]

Looks good! Any plan on merge / release?

[aboutlo]

v1.0.4 has been. published