expose fastify server in websocket handlers #67
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes fastify server in global and per route websocket handlers via
thisbinding.Adds tests to ensure this is the case in both kinds of handlers.
Adds a note in README to alert users about fastify request lifecycle expectations and clue them into the exposed server inside han dlers.
The typings for per route handlers seemed to already declare that
thiswas bound to the fastify instance even if in reality that was not the case.Fixes #66
Checklist
npm run testandnpm run benchmark