Skip to content

refactor(index): throw typeerror if condition is checking type #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2025
Merged

refactor(index): throw typeerror if condition is checking type #321

merged 1 commit into from
Jan 10, 2025

Conversation

@Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Jan 10, 2025

TypeError is more suitable than Error for these checks.

Checklist

@Fdawgs
refactor(index): throw typeerror if condition is checking type
cd7e211 
Signed-off-by: Frazer Smith <frazer.dev@icloud.com>
@Fdawgs Fdawgs merged commit e1ad31b into master Jan 10, 2025
13 checks passed
@Fdawgs Fdawgs deleted the Fdawgs-patch-2 branch January 10, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Fdawgs