-
-
Notifications
You must be signed in to change notification settings - Fork 83
Update for Fastify v5 #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Ok, will start merging now, but just for consistency, I've so far kept the .taprc files and haven't moved tap options to package.json as so far we've preferred explicit config files So it would be great if you could keep https://github.com/fastify/fastify-cookie/blob/next/.taprc |
Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day>
mcollina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
CI is failing |
|
Hey @synapse sorry for this, but master had a breaking change and it requires some refactoring, do you have time to take a look? |
gurgunday
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thank you!
Ref: fastify/fastify#5116
Checklist
npm run testandnpm run benchmarkand the Code of conduct