Skip to content

Conversation

@synapse
Copy link

@synapse synapse commented Mar 18, 2024

Ref: fastify/fastify#5116

Checklist

@gurgunday
Copy link
Member

Ok, will start merging now, but just for consistency, I've so far kept the .taprc files and haven't moved tap options to package.json as so far we've preferred explicit config files

So it would be great if you could keep .taprc, thanks

https://github.com/fastify/fastify-cookie/blob/next/.taprc
https://github.com/fastify/fastify-rate-limit/blob/next/.taprc

@gurgunday gurgunday changed the base branch from next to master April 15, 2024 18:25
@gurgunday gurgunday changed the base branch from master to next April 15, 2024 18:26
Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day>
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

CI is failing

@gurgunday
Copy link
Member

Hey @synapse sorry for this, but master had a breaking change and it requires some refactoring, do you have time to take a look?

@synapse synapse requested a review from gurgunday May 9, 2024 10:20
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@gurgunday gurgunday merged commit 486276a into fastify:next May 10, 2024
mcollina pushed a commit that referenced this pull request Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants