Skip to content

Conversation

@XHFkindergarten
Copy link
Contributor

@XHFkindergarten XHFkindergarten commented Dec 19, 2023

closes #280

Checklist

@fastify fastify deleted a comment from XHFkindergarten Dec 19, 2023
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test for this type change? We use tsd.

@XHFkindergarten
Copy link
Contributor Author

Could you add a test for this type change? We use tsd.

done,I think a default type check is enough.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit d7462d8 into fastify:master Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix a typescript generic type error

3 participants