-
-
Notifications
You must be signed in to change notification settings - Fork 214
feat(swagger): skip websocket routes #872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(swagger): skip websocket routes #872
Conversation
mcollina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of spurious changes - I think from prettier.
c83ac4a to
670ad57
Compare
mcollina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
gurgunday
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
I somehow wonder, why the websocket Attribute is so special. Are you setting it manually? Or is it because a Plugin is setting it? |
@Uzlopak it comes from fastify-websocket |
|
Can we consider implementing it differently? Maybe creating a Symbol. Like And in fastify websocket we set the route additionally to websocket true also that Symbol to true. And then we have a generic way to hide Routes. Without implementing for every possible plugin an exception. Also with that Symbol.for we loosely "bind" the plugins. I would prefer this tbh.. |
|
What do you think about my proposal? |
|
We already have the known |
|
Skip routes when
websocket: true