Skip to content

Conversation

@JohanManders
Copy link
Contributor

Before this commit, when using signed: true inside the cookie settings for fastify-secure-session, the cookie was passed without unsigning the cookie, so it would always be invalid. After this commit, signed sessions should work fine.

I added a test file to show it works and that tampering the cookie will invalidate a signed cookie. The test will fail in the old version.

Checklist

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 854b84c into fastify:master Apr 12, 2024
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants