Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: migrate from tap to node:test and c8 #107

Merged
merged 2 commits into from
Aug 16, 2024
Merged

fix: migrate from tap to node:test and c8 #107

merged 2 commits into from
Aug 16, 2024

Conversation

dancastillo
Copy link
Member

Checklist

This PR removes tap and uses node:test and. c8

Uzlopak
Uzlopak approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Uzlopak
Copy link
Contributor

Uzlopak commented Aug 15, 2024

Is c8 by default set for 100% Test coverage?

gurgunday
gurgunday requested changes Aug 15, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@dancastillo dancastillo requested a review from gurgunday August 15, 2024 13:11
@Eomm Eomm merged commit e6832af into fastify:master Aug 16, 2024
11 checks passed
@Uzlopak Uzlopak mentioned this pull request Aug 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurgunday gurgunday gurgunday approved these changes

@Eomm Eomm Eomm approved these changes

@Uzlopak Uzlopak Uzlopak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dancastillo @Uzlopak @Eomm @gurgunday