Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: migrate to fastify reusable workflow #74

Merged
merged 4 commits into from
Jul 19, 2022
Merged

ci: migrate to fastify reusable workflow #74

merged 4 commits into from
Jul 19, 2022

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented May 9, 2022

Checklist

@mcollina
Copy link
Member

CI fails :(

@Fdawgs
Copy link
Member Author

Fdawgs commented May 26, 2022

Requires #76

@Eomm Eomm mentioned this pull request May 31, 2022
@Eomm Eomm mentioned this pull request Jul 16, 2022
- uses: fastify/github-action-merge-dependabot@v3
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
uses: fastify/workflows/.github/workflows/plugins-ci.yml@v3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add the linting too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting is already part of this module's test script

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean to split the package.json script to run it once

@Fdawgs Fdawgs requested a review from Eomm July 19, 2022 07:18
@Eomm Eomm merged commit 3b2857a into master Jul 19, 2022
@Eomm Eomm deleted the Fdawgs-patch-1 branch July 19, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants