fix: handle closed HTTP/2 sessions after GOAWAY #431
Merged
+129
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue #409 where HTTP/2 sessions would get stuck after receiving a GOAWAY frame from the server.
Changes
Problem Description
When an HTTP/2 server sends a GOAWAY frame, the Node.js session gets closed but not necessarily destroyed. The original code only checked , causing the proxy to get stuck using a closed session that cannot accept new streams.
This resulted in all subsequent requests failing with errors, particularly affecting long-running connections like GraphQL subscriptions.
Solution
Changed the session check from:
to:
This ensures that:
Test Plan
Fixes #409