-
-
Notifications
You must be signed in to change notification settings - Fork 90
Feat/ balancedPool add #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM
@gulbaki I think this is not compatible with #157. Even type in https://github.com/fastify/fastify-reply-from/pull/157/files#diff-7aa4473ede4abd9ec099e87fec67fd57afafaf39e05d493ab4533acc38547eb8R54 is not adjusted. |
Array.isArray(opts.base) && opts.base.length > 1
instantiate
new undici.BalancedPool(origins, undiciOpts)
.fixes: Support load balancing across multiple base urls. #208
Checklist
npm run test
andnpm run benchmark
and the Code of conduct