add: error object to custom retry callback

[MikePresman]

This change introduces passing the error object to the custom retry callback; something that should've been done in the initial implementation of this feature but forgotten. Alas this PR introduces passing the error object to the callback.

Checklist

• run npm run test and npm run benchmark
• tests and/or benchmarks are included
• documentation is changed or added
• commit message and code follows the Developer's Certification of Origin
  and the Code of conduct

[airhorns]

@MikePresman want to just include the types PR in this one and adjust the types, and we can merge it together and close the other one?

[mcollina]

There are a lot of CI failures

[MikePresman]

Apologies about the previous failing tests and lint, had pushed and it slipped my mind to check when I grabbed lunch. All should be well now.

[gurgunday]

lgtm, breaking change

[Eomm]

Not a major, this feature is not yet released
Here is the discussion
#337 (comment)

I'm not going to approve as my comment is not solved, feel free to land it if you disagree 👍

[MikePresman]

Not a major, this feature is not yet released Here is the discussion #337 (comment)

I'm not going to approve as my comment is not solved, feel free to land it if you disagree 👍

Could you please clarify, I've made the change to interfacing the function args as an object which is what I believe was the core of your comment unless you meant

The most common use I see:
after 4 retries I want to log the message, otherwise ignore it.

For this reason I think this object will change soonish

passing the logger is something you want in this PR.

[gurgunday]

I'm not going to approve as my comment is not solved, feel free to land it if you disagree 👍

I personally wouldn't merge without making sure that we're all in agreement

Hasn't your proposal been implemented?

[mcollina]

lgtm

[MikePresman]

Not sure why my above type definition change would have failed the test as no functional changes between HEAD and HEAD~1 should have led to this imo. Could someone kindly re run it? I'm unable to reproduce this on my macos machine.

Edit: It was reran thank you.

[Uzlopak]

@MikePresman

Did you address all remarks of @airhorns ? If so, could you comment on them accordingly and resolve them please?

[airhorns]

LGTM after comments

[Uzlopak]

RSLGTM