reset request body when proxy get request from fastify #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
reviewed
May 27, 2018
index.js
Outdated
| // when proxy this request, we should reset the content-length to make it a valid http request | ||
| // discussion: https://github.com/fastify/fastify/issues/953 | ||
| if (req.method === 'GET') { | ||
| headers['content-length'] = Buffer.byteLength(body) |
There was a problem hiding this comment.
I would reset it to zero. GETs do not have bodies, and we should not forward them.
|
Sure, my original thought is future compatibility if we want to use the body in some way. But I agree with you, we don't need think that way. I will change it. |
|
updated @mcollina |
delvedor
reviewed
May 28, 2018
| // fastify ignore message body when it's a GET request | ||
| // when proxy this request, we should reset the content-length to make it a valid http request | ||
| // discussion: https://github.com/fastify/fastify/issues/953 | ||
| if (req.method === 'GET') { |
There was a problem hiding this comment.
We should do the same for HEAD requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according to https://tools.ietf.org/html/rfc2616#section-4.3. fastify ignore message body when it's a GET request. when proxy this request, we should reset the content-length to make it a valid http request discussion: fastify/fastify#953