Skip to content

Support webpack #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2020
Merged

Support webpack #97

merged 1 commit into from
Aug 4, 2020

Conversation

@mcollina
Copy link
Member

@mcollina mcollina commented Aug 4, 2020

Fix #96

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • commit message and code follows Code of conduct

@mcollina mcollina requested review from Eomm, delvedor and jsumners August 4, 2020 11:02
@mcollina
Copy link
Member Author

mcollina commented Aug 4, 2020

cc @Johann-S

jsumners
jsumners reviewed Aug 4, 2020
View reviewed changes
@Johann-S
Copy link

Johann-S commented Aug 4, 2020

Thanks @mcollina 👍

delvedor
delvedor approved these changes Aug 4, 2020
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jsumners
jsumners approved these changes Aug 4, 2020
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit 942159b into master Aug 4, 2020
@mcollina mcollina deleted the webpack branch August 4, 2020 17:39
@coreyfarrell coreyfarrell mentioned this pull request Aug 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsumners jsumners jsumners approved these changes

@delvedor delvedor delvedor approved these changes

@Eomm Eomm Awaiting requested review from Eomm

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fastify-plugin cannot be bundle

5 participants

@mcollina @Johann-S @jsumners @delvedor