Skip to content

Conversation

PabloSzx
Copy link
Contributor

@PabloSzx PabloSzx commented Sep 12, 2020

As it is right now, it is impossible to customize the logging level of the Next.js routes, even though the plugin type definitions have autoComplete for logLevel, and this PR reuses the plugin options logLevel config.

The test added fails if the changes in index.js are reverted.

@PabloSzx
Copy link
Contributor Author

The tests are failling in CI but in local they are fine 🤔

@zekth
Copy link
Member

zekth commented Sep 12, 2020

The tests are failling in CI but in local they are fine 🤔

          diff: |
            --- expected
            +++ actual
            @@ -1,1 +1,1 @@
            -application/javascript; charset=UTF-8
            +text/html; charset=utf-8
          ...

May you missed committing something?

@PabloSzx
Copy link
Contributor Author

PabloSzx commented Sep 12, 2020

The tests are failling in CI but in local they are fine 🤔

          diff: |
            --- expected
            +++ actual
            @@ -1,1 +1,1 @@
            -application/javascript; charset=UTF-8
            +text/html; charset=utf-8
          ...

May you missed committing something?

No, everything is fine, 56/56 passed, but the coverage is picking up the .next files, but I didn't change anything about that.

EDIT: I think some tests are failling (the /_next/* static tests) because of changes in dependencies, since the lock files are not commited, and I'm pretty sure that without my changes the tests would fail anyways.

@zekth
Copy link
Member

zekth commented Sep 12, 2020

Indeed. Your tests are ok as i see. Maybe another PR to fix this issue. Any idea @fastify/plugins ?

@mcollina
Copy link
Member

A PR that fixes this would be welcomed, yes. Let's commit the lockfile for this one as it seems minor version of Next.js are breaking.

@PabloSzx
Copy link
Contributor Author

Let's commit the lockfile for this one as it seems minor version of Next.js are breaking.

done 👍

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit a5aef3c into fastify:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants