Skip to content

Conversation

melroy89
Copy link
Contributor

@melroy89 melroy89 commented Apr 6, 2024

Add this important note, it's currently not clear unless you read your plugin code.

When using connectionString with fastify-mysql, it will NO longer pass any options towards mysql2. This could be confusing for some people.

If you however still want to use a database URI string together with additional mysql configuration options for the mysql2 package, then consider using uri option instead together with your additional options (let's say you also want to change connectionLimit as well and still use a database URI).

Checklist

Signed-off-by: Melroy van den Berg <melroy@melroy.org>
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thx

@mcollina mcollina merged commit 87d60b8 into fastify:master Apr 9, 2024
@melroy89 melroy89 deleted the patch-1 branch April 10, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants