Fix test warnings #596
Merged
Fix test warnings #596
+37
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed fastify.listen() calls to avoid mixing callback and promise styles that caused FastifyWarning FSTWRN003. Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes Fastify warning FSTWRN003 by removing the problematic mixing of async/await and callback patterns in fastify.listen() calls across test files.
Key Changes:
- Removed
asynckeyword from callback functions passed tofastify.listen()in 25 test cases - Converted one test to use proper async/await pattern without callbacks
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/multipart.test.js | Removed async keyword from 8 fastify.listen() callback functions |
| test/multipart-security.test.js | Removed async keyword from 6 fastify.listen() callback functions |
| test/multipart-json.test.js | Removed async keyword from 8 fastify.listen() callback functions |
| test/multipart-http2.test.js | Converted test to properly use async/await with fastify.listen() instead of callback pattern |
| test/multipart-concat.test.js | Removed async keyword from 2 fastify.listen() callback functions |
| test/multipart-body-schema.test.js | Removed async keyword from 2 fastify.listen() callback functions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fdawgs
approved these changes
Oct 25, 2025
Uzlopak
approved these changes
Oct 25, 2025
|
Yes |
Signed-off-by: Aras Abbasi <aras.abbasi@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes FastifyWarning FSTWRN003 by removing async/callback mixing in listen calls.
Changed 26 instances across 6 test files.