fix: prevent uncaught exception from malformed multipart requests #595
+184
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When req.file() is called after any async operation, malformed multipart requests could cause uncaught exceptions that crash the Node.js process. This occurred because the file stream error was emitted before user code could attach error listeners. This fix adds an immediate error listener to file streams that catches "terminated early" errors from malformed multipart data and propagates them through the normal error handling flow, preventing process crashes while preserving normal stream error handling behavior. Fixes #594 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
gurgunday
reviewed
Oct 24, 2025
gurgunday
reviewed
Oct 24, 2025
- Prefix unused error parameter with underscore - Remove unused FormData import 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Removed the unused MultipartHandler type from TypeScript definitions to fix linting error. This type was not exported or used anywhere. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Replace tap test framework with node:test and node:assert for the uncaught exception tests. Changes include: - Replace tap imports with node:test and node:assert - Remove t.plan() calls (not needed in node:test) - Replace t.ok() with assert.ok() - Replace t.pass() with boolean flags and assertions All tests pass with node:test. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #594
This PR prevents uncaught exceptions that could crash the Node.js process when malformed multipart requests are received after an async operation in the request handler.
Problem
When
req.file(),req.files(), orreq.parts()is called after any async operation (e.g.,await someOperation()), malformed multipart requests cause an uncaught exception that crashes the process. This happens because:Solution
Added an immediate error listener to file streams in the
onFilehandler that:Changes
Testing
Following TDD principles:
The server now handles malformed requests gracefully with a 400 response instead of crashing.
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com