-
-
Notifications
You must be signed in to change notification settings - Fork 98
feat: Added fromParameters decorator. #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Paolo Insogna <paolo@cowtech.it>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tiny nit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor doc suggestion
Co-authored-by: Manuel Spigolon <behemoth89@gmail.com> Signed-off-by: Paolo Insogna <paolo@cowtech.it>
Co-authored-by: Manuel Spigolon <behemoth89@gmail.com> Signed-off-by: Paolo Insogna <paolo@cowtech.it>
@Eomm Do you mind merging and releasing this if possible? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Adding support for the
fromParameters
decorator, which can be used to simulate a routing via fastify-http-proxy.This is useful when you want to override the request URL.
Checklist
npm run test
andnpm run benchmark
and the Code of conduct