chore(types): add internalRewriteLocationHeader in ts types #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Valerian Crasnier <Aerys59@gmail.com>
Contributor
|
looks good, but can you add a simple typing test please? |
Signed-off-by: Valerian Crasnier <Aerys59@gmail.com>
Author
|
Nice, when do you think it's gonna be available to release ? Because rn some of my code is red due to the missing type |
Contributor
|
@fastify/leads Time for a release :)? |
thedavidprice
referenced
this pull request
in redwoodjs/graphql
Mar 27, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@fastify/http-proxy](https://togithub.com/fastify/fastify-http-proxy) | [`9.4.0` -> `9.5.0`](https://renovatebot.com/diffs/npm/@fastify%2fhttp-proxy/9.4.0/9.5.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify-http-proxy (@​fastify/http-proxy)</summary> ### [`v9.5.0`](https://togithub.com/fastify/fastify-http-proxy/releases/tag/v9.5.0) [Compare Source](https://togithub.com/fastify/fastify-http-proxy/compare/v9.4.0...v9.5.0) #### What's Changed - chore(.gitignore): add .tap/ dir by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify-http-proxy/pull/334](https://togithub.com/fastify/fastify-http-proxy/pull/334) - chore(types): add internalRewriteLocationHeader in ts types by [@​Xa3lis](https://togithub.com/Xa3lis) in [https://github.com/fastify/fastify-http-proxy/pull/335](https://togithub.com/fastify/fastify-http-proxy/pull/335) - build(deps-dev): bump [@​fastify/websocket](https://togithub.com/fastify/websocket) from 8.3.1 to 9.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify-http-proxy/pull/337](https://togithub.com/fastify/fastify-http-proxy/pull/337) - build(deps-dev): bump [@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser) from 6.21.0 to 7.1.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify-http-proxy/pull/339](https://togithub.com/fastify/fastify-http-proxy/pull/339) - chore: remove unused make-promises-safe by [@​10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) in [https://github.com/fastify/fastify-http-proxy/pull/342](https://togithub.com/fastify/fastify-http-proxy/pull/342) - Keep websocket path on proxy by [@​silnex](https://togithub.com/silnex) in [https://github.com/fastify/fastify-http-proxy/pull/341](https://togithub.com/fastify/fastify-http-proxy/pull/341) #### New Contributors - [@​Xa3lis](https://togithub.com/Xa3lis) made their first contribution in [https://github.com/fastify/fastify-http-proxy/pull/335](https://togithub.com/fastify/fastify-http-proxy/pull/335) - [@​10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) made their first contribution in [https://github.com/fastify/fastify-http-proxy/pull/342](https://togithub.com/fastify/fastify-http-proxy/pull/342) - [@​silnex](https://togithub.com/silnex) made their first contribution in [https://github.com/fastify/fastify-http-proxy/pull/341](https://togithub.com/fastify/fastify-http-proxy/pull/341) **Full Changelog**: fastify/fastify-http-proxy@v9.4.0...v9.5.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: David Price <thedavid@thedavidprice.com>
](https://renovatebot.com){kind=link}
thedavidprice
referenced
this pull request
in redwoodjs/graphql
Mar 27, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@fastify/http-proxy](https://togithub.com/fastify/fastify-http-proxy) | [`9.4.0` -> `9.5.0`](https://renovatebot.com/diffs/npm/@fastify%2fhttp-proxy/9.4.0/9.5.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify-http-proxy (@​fastify/http-proxy)</summary> ### [`v9.5.0`](https://togithub.com/fastify/fastify-http-proxy/releases/tag/v9.5.0) [Compare Source](https://togithub.com/fastify/fastify-http-proxy/compare/v9.4.0...v9.5.0) #### What's Changed - chore(.gitignore): add .tap/ dir by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify-http-proxy/pull/334](https://togithub.com/fastify/fastify-http-proxy/pull/334) - chore(types): add internalRewriteLocationHeader in ts types by [@​Xa3lis](https://togithub.com/Xa3lis) in [https://github.com/fastify/fastify-http-proxy/pull/335](https://togithub.com/fastify/fastify-http-proxy/pull/335) - build(deps-dev): bump [@​fastify/websocket](https://togithub.com/fastify/websocket) from 8.3.1 to 9.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify-http-proxy/pull/337](https://togithub.com/fastify/fastify-http-proxy/pull/337) - build(deps-dev): bump [@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser) from 6.21.0 to 7.1.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify-http-proxy/pull/339](https://togithub.com/fastify/fastify-http-proxy/pull/339) - chore: remove unused make-promises-safe by [@​10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) in [https://github.com/fastify/fastify-http-proxy/pull/342](https://togithub.com/fastify/fastify-http-proxy/pull/342) - Keep websocket path on proxy by [@​silnex](https://togithub.com/silnex) in [https://github.com/fastify/fastify-http-proxy/pull/341](https://togithub.com/fastify/fastify-http-proxy/pull/341) #### New Contributors - [@​Xa3lis](https://togithub.com/Xa3lis) made their first contribution in [https://github.com/fastify/fastify-http-proxy/pull/335](https://togithub.com/fastify/fastify-http-proxy/pull/335) - [@​10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) made their first contribution in [https://github.com/fastify/fastify-http-proxy/pull/342](https://togithub.com/fastify/fastify-http-proxy/pull/342) - [@​silnex](https://togithub.com/silnex) made their first contribution in [https://github.com/fastify/fastify-http-proxy/pull/341](https://togithub.com/fastify/fastify-http-proxy/pull/341) **Full Changelog**: fastify/fastify-http-proxy@v9.4.0...v9.5.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: David Price <thedavid@thedavidprice.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
The
internalRewriteLocationHeaderwas added some months ago, it's working fine but the TS types had not been updated, so this is a quick PR to add itChecklist
npm run testandnpm run benchmarkand the Code of conduct