Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(index): use spread over Object.assign() #257

Merged
merged 1 commit into from
Jul 20, 2023
Merged

perf(index): use spread over Object.assign() #257

merged 1 commit into from
Jul 20, 2023

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Jul 20, 2023

Nearly twice as fast, see https://github.com/RafaelGSS/nodejs-bench-operations/blob/main/RESULTS-v18.md#objectassign-vs-spread-operator

Checklist

@Fdawgs Fdawgs changed the title perf(index): use spread over object.assign() perf(index): use spread over Object.assign() Jul 20, 2023
@mcollina mcollina merged commit a7d0a62 into master Jul 20, 2023
@Fdawgs Fdawgs deleted the perf/spread branch July 20, 2023 19:41
Eomm
Eomm reviewed Jul 20, 2023
View reviewed changes
Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot_2023-07-20-22-43-28-44_320a9a695de7cdce83ed5281148d6f19.jpg

Are not we in the small object case?

@Uzlopak
Copy link
Contributor

Uzlopak commented Jul 20, 2023

Actually, it is not noticable for most cases. If you use a delegator, then you should notice.

@Fdawgs
Copy link
Member Author

Fdawgs commented Jul 21, 2023

Screenshot_2023-07-20-22-43-28-44_320a9a695de7cdce83ed5281148d6f19.jpg

Are not we in the small object case?

Original code was creating a new object, so according to that table it was ~9m vs ~16m

@Fdawgs
Copy link
Member Author

Fdawgs commented Jul 21, 2023 •
edited
Loading

Actually, it is not noticable for most cases. If you use a delegator, then you should notice.

Learnt something new today, thanks @Uzlopak!

Not worth looking at in other repos then?

@Uzlopak
Copy link
Contributor

Uzlopak commented Jul 21, 2023

I wouldnt say that. Here in fastify-cors if you dont use that delegator style, than you will call that object merging only once. If you use delegator than it should be merging the object on every request.

But there are potentially other repos where object merging happens on every request and not only on startup, where it is worth to investigate it further.

renovate bot referenced this pull request in tomacheese/telcheck Sep 19, 2023
@renovate
chore(deps): update dependency @fastify/cors to v8.4.0 (#296)
8ba5116 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@fastify/cors](https://togithub.com/fastify/fastify-cors) | [`8.3.0`
->
`8.4.0`](https://renovatebot.com/diffs/npm/@fastify%2fcors/8.3.0/8.4.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@fastify%2fcors/8.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@fastify%2fcors/8.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@fastify%2fcors/8.3.0/8.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@fastify%2fcors/8.3.0/8.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify-cors (@&#8203;fastify/cors)</summary>

###
[`v8.4.0`](https://togithub.com/fastify/fastify-cors/releases/tag/v8.4.0)

[Compare
Source](https://togithub.com/fastify/fastify-cors/compare/v8.3.0...v8.4.0)

#### What's Changed

- fix documentation, onRequest is default lifecycle stage by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[https://github.com/fastify/fastify-cors/pull/254](https://togithub.com/fastify/fastify-cors/pull/254)
- perf(index): use spread over `Object.assign()` by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[https://github.com/fastify/fastify-cors/pull/257](https://togithub.com/fastify/fastify-cors/pull/257)
- docs(readme): add plugin compatibility table by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[https://github.com/fastify/fastify-cors/pull/258](https://togithub.com/fastify/fastify-cors/pull/258)
- test: cors headers sent when payload is stream by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[https://github.com/fastify/fastify-cors/pull/260](https://togithub.com/fastify/fastify-cors/pull/260)
- Reduce bundle size by
[@&#8203;timedtext](https://togithub.com/timedtext) in
[https://github.com/fastify/fastify-cors/pull/266](https://togithub.com/fastify/fastify-cors/pull/266)
- chore(deps-dev): bump
[@&#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)
from 5.62.0 to 6.4.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/fastify/fastify-cors/pull/267](https://togithub.com/fastify/fastify-cors/pull/267)
- chore(deps-dev): bump tsd from 0.28.1 to 0.29.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/fastify/fastify-cors/pull/268](https://togithub.com/fastify/fastify-cors/pull/268)
- test: use `node:` prefix to bypass require.cache call for builtins by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[https://github.com/fastify/fastify-cors/pull/269](https://togithub.com/fastify/fastify-cors/pull/269)
- refactor(vary): use word character inside regex character class by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[https://github.com/fastify/fastify-cors/pull/270](https://togithub.com/fastify/fastify-cors/pull/270)

#### New Contributors

- [@&#8203;timedtext](https://togithub.com/timedtext) made their first
contribution in
[https://github.com/fastify/fastify-cors/pull/266](https://togithub.com/fastify/fastify-cors/pull/266)

**Full Changelog**:
fastify/fastify-cors@v8.3.0...v8.4.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/tomacheese/telcheck).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi45Ny4xIiwidXBkYXRlZEluVmVyIjoiMzYuOTcuMSIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
bodinsamuel referenced this pull request in specfy/specfy Nov 22, 2023
@renovate
fix(deps): update dependency @fastify/cors to v8.4.1 (#364)
d833395 
[![Mend Renovate logo
banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@fastify/cors](https://togithub.com/fastify/fastify-cors) | [`8.3.0`
->
`8.4.1`](https://renovatebot.com/diffs/npm/@fastify%2fcors/8.3.0/8.4.1)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@fastify%2fcors/8.4.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@fastify%2fcors/8.4.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@fastify%2fcors/8.3.0/8.4.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@fastify%2fcors/8.3.0/8.4.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify-cors (@&#8203;fastify/cors)</summary>

###
[`v8.4.1`](https://togithub.com/fastify/fastify-cors/releases/tag/v8.4.1)

[Compare
Source](https://togithub.com/fastify/fastify-cors/compare/v8.4.0...v8.4.1)

#### What's Changed

- Fix type of OriginCallback by
[@&#8203;ken-browning](https://togithub.com/ken-browning) in
[https://github.com/fastify/fastify-cors/pull/272](https://togithub.com/fastify/fastify-cors/pull/272)
- test: add `u` unicode flag to regex by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[https://github.com/fastify/fastify-cors/pull/273](https://togithub.com/fastify/fastify-cors/pull/273)
- chore(package): explicitly declare js module type by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[https://github.com/fastify/fastify-cors/pull/274](https://togithub.com/fastify/fastify-cors/pull/274)
- test(index): replace `typeof` undefined check by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[https://github.com/fastify/fastify-cors/pull/275](https://togithub.com/fastify/fastify-cors/pull/275)

#### New Contributors

- [@&#8203;ken-browning](https://togithub.com/ken-browning) made their
first contribution in
[https://github.com/fastify/fastify-cors/pull/272](https://togithub.com/fastify/fastify-cors/pull/272)

**Full Changelog**:
fastify/fastify-cors@v8.4.0...v8.4.1

###
[`v8.4.0`](https://togithub.com/fastify/fastify-cors/releases/tag/v8.4.0)

[Compare
Source](https://togithub.com/fastify/fastify-cors/compare/v8.3.0...v8.4.0)

#### What's Changed

- fix documentation, onRequest is default lifecycle stage by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[https://github.com/fastify/fastify-cors/pull/254](https://togithub.com/fastify/fastify-cors/pull/254)
- perf(index): use spread over `Object.assign()` by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[https://github.com/fastify/fastify-cors/pull/257](https://togithub.com/fastify/fastify-cors/pull/257)
- docs(readme): add plugin compatibility table by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[https://github.com/fastify/fastify-cors/pull/258](https://togithub.com/fastify/fastify-cors/pull/258)
- test: cors headers sent when payload is stream by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[https://github.com/fastify/fastify-cors/pull/260](https://togithub.com/fastify/fastify-cors/pull/260)
- Reduce bundle size by
[@&#8203;timedtext](https://togithub.com/timedtext) in
[https://github.com/fastify/fastify-cors/pull/266](https://togithub.com/fastify/fastify-cors/pull/266)
- chore(deps-dev): bump
[@&#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)
from 5.62.0 to 6.4.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/fastify/fastify-cors/pull/267](https://togithub.com/fastify/fastify-cors/pull/267)
- chore(deps-dev): bump tsd from 0.28.1 to 0.29.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/fastify/fastify-cors/pull/268](https://togithub.com/fastify/fastify-cors/pull/268)
- test: use `node:` prefix to bypass require.cache call for builtins by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[https://github.com/fastify/fastify-cors/pull/269](https://togithub.com/fastify/fastify-cors/pull/269)
- refactor(vary): use word character inside regex character class by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[https://github.com/fastify/fastify-cors/pull/270](https://togithub.com/fastify/fastify-cors/pull/270)

#### New Contributors

- [@&#8203;timedtext](https://togithub.com/timedtext) made their first
contribution in
[https://github.com/fastify/fastify-cors/pull/266](https://togithub.com/fastify/fastify-cors/pull/266)

**Full Changelog**:
fastify/fastify-cors@v8.3.0...v8.4.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 4pm every weekday" in timezone
Europe/Paris, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/specfy/specfy).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6ImNob3JlL3Jlbm92YXRlQmFzZUJyYW5jaCJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@Bad3r Bad3r mentioned this pull request May 22, 2024
Open
@Bad3r Bad3r mentioned this pull request Jun 12, 2024
Open
@Summonshr Summonshr mentioned this pull request Jun 29, 2024
Open
This was referenced Sep 8, 2024
Open
Open
This was referenced Sep 17, 2024
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eomm Eomm Eomm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Fdawgs @Uzlopak @Eomm @mcollina