Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix origin example #204

Merged
merged 1 commit into from
May 24, 2022
Merged

Fix origin example #204

merged 1 commit into from
May 24, 2022

Conversation

christian-bromann
Copy link
Contributor

The OriginCallback is defined as:

type OriginCallback = (err: Error | null, allow: boolean) => void;

and therefore expects a second parameter even though I think this seems redundant given you already pass in an error. Anyway the example should be fixed to avoid confusion.

Checklist

@christian-bromann
Fix origin example
a6b0a72 
The `OriginCallback` is defined as:

```ts
type OriginCallback = (err: Error | null, allow: boolean) => void;
```

and therefore expects a second parameter even though I think this seems redundant given you already pass in an error. Anyway the example should be fixed to avoid confusion.
mcollina
mcollina approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit d0ec096 into fastify:master May 24, 2022
@mcollina
Copy link
Member

thx!

@christian-bromann christian-bromann deleted the patch-1 branch May 24, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christian-bromann @mcollina