-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cors options pass by promise #130
Conversation
Pull Request Test Coverage Report for Build 819366967
💛 - Coveralls |
Pull Request Test Coverage Report for Build 819366967
💛 - Coveralls |
Pull Request Test Coverage Report for Build 819383836
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I didn't understand the issue linked, I'm trusting you:( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@mcollina zekth explaination is correct for the issue, should we publish as |
I'll do a patch - this is a fix. |
Resolve: #129
Changes:
Checklist
npm run test
andnpm run benchmark
and the Code of conduct